From: norm.grant@wmich.edu Sent: Monday, November 04, 2002 1:31 PM To: Everhart, Glenn (Card Services) Subject: RE: CSWING updates Looking over the help code, I find a routine help$get_input which is supposed to have the same call as LIB$GET_INPUT -- which means the third argument should be a pointer to an unsigned short, rather than an the int it is. Hopefully, that is what he was looking at. If so, the dif would be: ************ File DISK$UCS:[GRANT.CSWING]swing_9.c;11 52 USHORT input_length; 53 ULONG input_status; 54 ****** File DISK$UCS:[GRANT.CSWING]swing_9.c;10 52 int input_length; 53 int input_status; 54 ************ ************ File DISK$UCS:[GRANT.CSWING]swing_9.c;11 62 USHORT *x_input_length); 63 static ULONG help$put_output(struct dsc$descriptor *output); ****** File DISK$UCS:[GRANT.CSWING]swing_9.c;10 62 int x_input_length); 63 static ULONG help$put_output(struct dsc$descriptor *output); ************ ************ File DISK$UCS:[GRANT.CSWING]swing_9.c;11 240 USHORT *x_input_length) 241 { ****** File DISK$UCS:[GRANT.CSWING]swing_9.c;10 240 int x_input_length) 241 { ************ ************ File DISK$UCS:[GRANT.CSWING]swing_9.c;11 262 *x_input_length = input_length; 263 ****** File DISK$UCS:[GRANT.CSWING]swing_9.c;10 262 x_input_length = input_length; 263 ************ Number of difference sections found: 4 Number of difference records found: 5 DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK$UCS:[GRANT.CSWING]SWING_9.DIF;1- DISK$UCS:[GRANT.CSWING]swing_9.c;11- DISK$UCS:[GRANT.CSWING]swing_9.c;10 > Thanks. Will apply this myself. BTW John Malmberg alluded to some problem where > a help function request was passing a length rather than a pointer to a variable > to receive a length read. I looked for such briefly and did not find any such thing > in your code though. Asked for specifics... > Glenn > -----Original Message----- > From: norm.grant@wmich.edu [mailto:norm.grant@wmich.edu] > Sent: Monday, November 04, 2002 9:51 AM > To: Everhart, Glenn (Card Services); dallen@nist.gov > Subject: CSWING updates > I've fixed a problem that Dan Allen pointed out, added Carlos Costa's > fix to get_dirs, and corrected some cases where channel should have been > a ULONG (I converted all channels to USHORT). > Here are the Difs: > ************ > File DISK$UCS:[GRANT.CSWING]swing.h;81 > 554 int get_dirs(NODE *n_ptr, ULONG channel); > 555 int get_dir_files(NODE *n, int file_type); > ****** > File DISK$UCS:[GRANT.CSWING]swing.h;80 > 554 int get_dirs(NODE *n_ptr, USHORT channel); > 555 int get_dir_files(NODE *n, int file_type); > ************ > Number of difference sections found: 1 > Number of difference records found: 1 > DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK$UCS:[GRANT.CSWING]SWING_C.DIF;2- > DISK$UCS:[GRANT.CSWING]swing.h;81- > DISK$UCS:[GRANT.CSWING]swing.h;80 > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;25 > 528 filename[0] = 0; > 529 file_length = 0; > 530 > 531 while(1) > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 528 while(1) > ************ > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;25 > 535 uchar = 0; > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 532 filename[0] = 0; > 533 file_length = 0; > 534 uchar = 0; > ************ > Number of difference sections found: 2 > Number of difference records found: 5 > DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK$UCS:[GRANT.CSWING]X.;5- > DISK$UCS:[GRANT.CSWING]swing.c;25- > DISK$UCS:[GRANT.CSWING]swing.c;24 > > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 493 int get_dirs(NODE *n_ptr, ULONG channel) > 494 { > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;23 > 493 int get_dirs(NODE *n_ptr, USHORT channel) > 494 { > ************ > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 1000 (ULONG) op_channel, > 1001 IO$_SETMODE, > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;23 > 1000 op_channel, > 1001 IO$_SETMODE, > ************ > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 1099 (ULONG) op_channel, > 1100 IO$_SENSEMODE, > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;23 > 1099 op_channel, > 1100 IO$_SENSEMODE, > ************ > ************ > File DISK$UCS:[GRANT.CSWING]swing.c;24 > 1120 (ULONG) op_channel, > 1121 IO$_SETMODE, > ****** > File DISK$UCS:[GRANT.CSWING]swing.c;23 > 1120 op_channel, > 1121 IO$_SETMODE, > ************ > Number of difference sections found: 4 > Number of difference records found: 4 > DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK$UCS:[GRANT.CSWING]SWING_C.DIF;1- > DISK$UCS:[GRANT.CSWING]swing.c;24- > DISK$UCS:[GRANT.CSWING]swing.c;23 > > ************ > File DISK$UCS:[GRANT.CSWING]swing_24.c;9 > 459 DSC2(head) , > 460 &acmode, > ****** > File DISK$UCS:[GRANT.CSWING]swing_24.C_BAD;1 > 459 DSCA2(head) , > 460 &acmode, > ************ > Number of difference sections found: 1 > Number of difference records found: 1 > DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK$UCS:[GRANT.CSWING]SWING_24.DIF;1- > DISK$UCS:[GRANT.CSWING]swing_24.c;9- > DISK$UCS:[GRANT.CSWING]swing_24.C_BAD;1 > ------------- > Norman D. Grant INTERNET: norm.grant@wmich.edu > Western Michigan University Voice: (616) 387-5449 > Office of Information Technology/UCS > Kalamazoo, MI 49008 > ********************************************************************** > This transmission may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you > ********************************************************************** ------------- Norman D. Grant INTERNET: norm.grant@wmich.edu Western Michigan University Voice: (616) 387-5449 Office of Information Technology/UCS Kalamazoo, MI 49008