Subject: Re: OpenVMS 7.3-1 and CSWING From: "John E. Malmberg" Date: Tue, 07 Jan 2003 15:49:52 -0600 (CST) To: Glenn and Mary Everhart Glen, I have been reviewing your changes to swing.c and found an error. The prototypes for SYS$QIO(W) on older documentation show that the channel is passed as an unsigned long. The channel number is actually an unsigned short, and I have discovered that using GCC/VAX if you assign a channel to an unsigned long, the SYS$ASSIGN does not zero the high word, and if you then pass that channel to the SYS$QIOW call, it will subsequently fail because the SYS$QIO call apparently is checking the upper bits. Also while it is unlikely that enough channels would be in use that a sign extension would occur, that would also cause the QIO to fail. Other than that so far your changes swing.c are almost equivalent to mine, I noticed that you changed some type names and some variable names. I have not been using the nnn$routines.h for prototypes because IMHO, the prototypes are not properly done. I have made a set of nnn_routines.h that more correctly do the job. This found a coding error in the exit handler where one of the functions was returning an insufficient arguments status (ignored) instead of doing a cleanup. I suspect that the image rundown handler actually did the fixup, so the broken routine was never noticed. I also in swing.c fixed it so that it no longer illegaly maniplated the wcc context variable, and corrected the stripping of the directory suffix to comply with ODS-5. I am now slowly going through the code to make it compliant with ODS-5 and long filenames. I had a version that is building with 0 compiler diagnostics right now, and it is mostly running. I have not yet tested out the help function which I needed to rewrite a little bit. I thought that before I went to far with the ODS-5 stuff, that I should review what you did though. -John malmberg@encompasserve.org Personal Opinion Only >>> > > >> John - >> Here is a version with a number more fixes. Just sources, but the product >> does build ok on my alpha. >> >> Glenn Everhart >> >>